Skip to content

Convert :not pseudo-class selector list to chained #9561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Convert :not pseudo-class selector list to chained #9561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e6cb39
Convert :not pseudo-class selector list to chained
aaronccasanova Jun 28, 2023
bd0b8b8
Merge branch 'main' of https://github.com/shopify/polaris into fix-no…
aaronccasanova Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions polaris-react/src/components/Button/Button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@
}

#{$se23} &:hover,
#{$se23} &:focus:not(:active, .pressed, .disabled) {
#{$se23} &:focus:not(:active):not(.pressed):not(.disabled) {
Copy link
Member

@chloerice chloerice Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophat of AppIndexResourceListItem looks good 🥇

Screenshot 2023-06-29 at 6 57 18 PM

color: var(--p-color-text-critical-hover-experimental);

// stylelint-disable-next-line -- se23 override
Expand Down Expand Up @@ -1020,7 +1020,7 @@
}
}

#{$se23} &:focus:not(:active, .pressed, .disabled) svg {
#{$se23} &:focus:not(:active):not(.pressed):not(.disabled) svg {
fill: var(--p-color-icon-critical-strong-experimental);
}

Expand Down
2 changes: 1 addition & 1 deletion polaris-react/src/components/DropZone/DropZone.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ $dropzone-stacking-order: (
}
}

#{$se23} &:not(.focused, .isDisabled) {
#{$se23} &:not(.focused):not(.isDisabled) {
Copy link
Member

@chloerice chloerice Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophat of the ProductDetails DropZone looks good 💯

Screenshot 2023-06-29 at 4 52 35 PM

// the additional .isDisabled argument in this :not invocation is to ensure we don't mess up disabled styles due to specificity.
// Won't be necessary post SE23.
&::after {
Expand Down
4 changes: 3 additions & 1 deletion polaris-react/src/components/ResourceItem/ResourceItem.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,13 @@
}
}

&:not(.hasBulkActions, .selectMode) {
Copy link
Member Author

@aaronccasanova aaronccasanova Jun 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This PR updates a mainline :not psuedo-class (e.g. not beta-flagged) (Screenshot in PR description)

&:not(.hasBulkActions):not(.selectMode) {
Copy link
Member

@chloerice chloerice Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophat of ProductDetails OptionsAndVariantsCard with multi-location looks good 👍🏽

Screenshot 2023-06-29 at 6 47 24 PM

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
&::after {
border-radius: var(--p-border-radius-05);
}

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
&:last-of-type {
border-bottom-left-radius: var(--p-border-radius-2);
border-bottom-right-radius: var(--p-border-radius-2);
Expand Down