Skip to content

Add optimize script #9580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2023
Merged

Add optimize script #9580

merged 2 commits into from
Jun 30, 2023

Conversation

@kyledurand
Copy link
Member

@kyledurand kyledurand commented Jun 30, 2023

No description provided.

@kyledurand kyledurand requested a review from sam-b-rose June 30, 2023 14:25
@kyledurand kyledurand requested a review from Rusty-UX June 30, 2023 14:31
sam-b-rose
sam-b-rose approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just for my own understanding, this is so we can optimize the source icons and the bundled React icons as well?

@kyledurand
Copy link
Member Author

kyledurand commented Jun 30, 2023

Just the source icons. Makes it easier to contribute a bundle like @Rusty-UX is doing for RTE icons. Before we pretty much had to one off them in https://jakearchibald.github.io/svgomg/ with the right toggles

@kyledurand kyledurand merged commit 75f08f3 into main Jun 30, 2023
@kyledurand kyledurand deleted the add-optimize-script branch June 30, 2023 15:11
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jun 30, 2023
Merged
aaronccasanova
aaronccasanova reviewed Jun 30, 2023
View reviewed changes
polaris-icons/package.json
"dev": "rollup -c -w",
"test": "jest",
"clean": "rm -rf .turbo node_modules dist"
"optimize": "yarn svgo -f icons",
Copy link
Member

@aaronccasanova aaronccasanova Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up @kyledurand and @samrose3, I don't think yarn is needed here. svgo's bin script should automatically be symlinked to node_modules/.bin and thus available to the run-script:
See here:

When this package is installed as a dependency in another package, the file will be linked where it will be available to that package either directly by npm exec or by name in other scripts when invoking them via npm run-script.

Copy link
Member

@sam-b-rose sam-b-rose Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and great point!

Copy link
Member Author

@kyledurand kyledurand Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

kyledurand pushed a commit that referenced this pull request Jun 30, 2023
@shopify-github-actions-access @github-actions
Version Packages (#9562)
8df57f3 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.2.0

### Minor Changes

- [#9581](#9581)
[`991d9fe69`](991d9fe)
Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Added BoldMajor,
BoldMinor, IndentMajor, IndentMinor, ItalicMajor, ItalicMinor,
OrderedListMajor, OrderedListMinor, OutdentMajor, OutdentMinor,
TextColorMajor, TextColorMinor, UnderlineMajor, UnderlineMinor icons


- [#9580](#9580)
[`75f08f32c`](75f08f3)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added optimize
script

## @shopify/polaris@11.3.1

### Patch Changes

- [#9556](#9556)
[`c72d2f905`](c72d2f9)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! -
Restructured `Select` override selectors to patch Sass compilation issue


- [#9031](#9031)
[`795ae3782`](795ae37)
Thanks [@danbrady](https://github.com/danbrady)! - Added support for
`Avatar` being presentational

- Updated dependencies
\[[`991d9fe69`](991d9fe),
[`75f08f32c`](75f08f3)]:
    -   @shopify/polaris-icons@7.2.0

## @shopify/polaris-cli@0.2.10



## polaris.shopify.com@0.55.8

### Patch Changes

- Updated dependencies
\[[`c72d2f905`](c72d2f9),
[`795ae3782`](795ae37),
[`991d9fe69`](991d9fe),
[`75f08f32c`](75f08f3)]:
    -   @shopify/polaris@11.3.1
    -   @shopify/polaris-icons@7.2.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@kyledurand @juzser
Add optimize script (Shopify#9580)
5620031
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@shopify-github-actions-access @github-actions @juzser
Version Packages (Shopify#9562)
1997ea8 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.2.0

### Minor Changes

- [Shopify#9581](Shopify#9581)
[`991d9fe69`](Shopify@991d9fe)
Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Added BoldMajor,
BoldMinor, IndentMajor, IndentMinor, ItalicMajor, ItalicMinor,
OrderedListMajor, OrderedListMinor, OutdentMajor, OutdentMinor,
TextColorMajor, TextColorMinor, UnderlineMajor, UnderlineMinor icons


- [Shopify#9580](Shopify#9580)
[`75f08f32c`](Shopify@75f08f3)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added optimize
script

## @shopify/polaris@11.3.1

### Patch Changes

- [Shopify#9556](Shopify#9556)
[`c72d2f905`](Shopify@c72d2f9)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! -
Restructured `Select` override selectors to patch Sass compilation issue


- [Shopify#9031](Shopify#9031)
[`795ae3782`](Shopify@795ae37)
Thanks [@danbrady](https://github.com/danbrady)! - Added support for
`Avatar` being presentational

- Updated dependencies
\[[`991d9fe69`](Shopify@991d9fe),
[`75f08f32c`](Shopify@75f08f3)]:
    -   @shopify/polaris-icons@7.2.0

## @shopify/polaris-cli@0.2.10



## polaris.shopify.com@0.55.8

### Patch Changes

- Updated dependencies
\[[`c72d2f905`](Shopify@c72d2f9),
[`795ae3782`](Shopify@795ae37),
[`991d9fe69`](Shopify@991d9fe),
[`75f08f32c`](Shopify@75f08f3)]:
    -   @shopify/polaris@11.3.1
    -   @shopify/polaris-icons@7.2.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@kyledurand
Add optimize script (Shopify#9580)
01fb273
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
@shopify-github-actions-access @github-actions
Version Packages (Shopify#9562)
c10d1c2 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.2.0

### Minor Changes

- [Shopify#9581](Shopify#9581)
[`991d9fe69`](Shopify@a847d9c)
Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Added BoldMajor,
BoldMinor, IndentMajor, IndentMinor, ItalicMajor, ItalicMinor,
OrderedListMajor, OrderedListMinor, OutdentMajor, OutdentMinor,
TextColorMajor, TextColorMinor, UnderlineMajor, UnderlineMinor icons


- [Shopify#9580](Shopify#9580)
[`75f08f32c`](Shopify@01fb273)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added optimize
script

## @shopify/polaris@11.3.1

### Patch Changes

- [Shopify#9556](Shopify#9556)
[`c72d2f905`](Shopify@0c270b0)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! -
Restructured `Select` override selectors to patch Sass compilation issue


- [Shopify#9031](Shopify#9031)
[`795ae3782`](Shopify@c68e956)
Thanks [@danbrady](https://github.com/danbrady)! - Added support for
`Avatar` being presentational

- Updated dependencies
\[[`991d9fe69`](Shopify@a847d9c),
[`75f08f32c`](Shopify@01fb273)]:
    -   @shopify/polaris-icons@7.2.0

## @shopify/polaris-cli@0.2.10



## polaris.shopify.com@0.55.8

### Patch Changes

- Updated dependencies
\[[`c72d2f905`](Shopify@0c270b0),
[`795ae3782`](Shopify@c68e956),
[`991d9fe69`](Shopify@a847d9c),
[`75f08f32c`](Shopify@01fb273)]:
    -   @shopify/polaris@11.3.1
    -   @shopify/polaris-icons@7.2.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sam-b-rose sam-b-rose sam-b-rose approved these changes

@aaronccasanova aaronccasanova aaronccasanova left review comments

@Rusty-UX Rusty-UX Awaiting requested review from Rusty-UX

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kyledurand @sam-b-rose @aaronccasanova