Skip to content

Conversation

@kangjoa
Copy link
Collaborator

@kangjoa kangjoa commented Nov 26, 2025

Partially resolves issue #21021

Description

Migrates remaining tutorial code from ui-extensions to this centralized tutorial repo (see issue for more details). The coordinating tutorials will be updated in the dev docs to use these new links.

What's included

  • example-pos-ui-extensions--discounts--preact: Discount extension tutorial
  • example-pos-ui-extensions--printer--preact: Printer extension with full app setup
  • example-pos-ui-extensions--localize--preact: removes values for client_id and author

Tophat

  • Copy the tutorial code, install dependencies with npm install, start development with shopify app dev and follow CLI prompts to reset. Apps will be runnable.

@kangjoa kangjoa self-assigned this Nov 26, 2025
@kangjoa kangjoa requested review from a team and vctrchu November 26, 2025 21:55
Copy link

@vctrchu vctrchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start but I think we should keep the examples as clean as we can by minimizing what we commit.

Could you try mirroring the customer-accounts examples?

@kangjoa kangjoa force-pushed the add-tutorial-code branch 2 times, most recently from 7a79636 to 963d16b Compare December 2, 2025 01:23
@kangjoa kangjoa requested a review from vctrchu December 2, 2025 01:28
@@ -0,0 +1,18 @@
FROM node:20-alpine
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the Docker and config files based on the other app tutorials, including the Build a Shopify app using React Router tutorial

@vctrchu vctrchu requested a review from a team December 2, 2025 23:13
@vctrchu
Copy link

vctrchu commented Dec 3, 2025

I tried testing the print extension tutorial by just copy pasting all the files but ran into some blockers which require the developer to actually initialize their own app first. I'm not sure how much value we get from committing all the template files from the react router template.

How about instead, we only commit the extensions folder & the app folder since those are crucial for the tutorial?

UPDATE: we will use only update the client id for each app toml file but keep everything that is generated from the templates to make running the extension easy for developers.

@vctrchu
Copy link

vctrchu commented Dec 3, 2025

~~ We should update the READ on instructions on how to run each app ~~
~~- cd the app you want to run ~~
~~- shopify app dev --reset ~~

We talked and agreed there is already sufficient documentation in each example READ ME + CLI warnings.

@kangjoa kangjoa requested a review from vctrchu December 4, 2025 20:10
Copy link

@vctrchu vctrchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kangjoa kangjoa merged commit 5abe222 into main Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants