This repository was archived by the owner on Jan 10, 2025. It is now read-only.
✨ add additional error message is the type passed in is null or undef…#1047
Merged
✨ add additional error message is the type passed in is null or undef…#1047
Conversation
michenly
force-pushed
the
check-type
branch
2 times, most recently
from
2b7ae40 to
2b1215e
Compare
cartogram
approved these changes
Sep 26, 2019
| matcherHint(`.${expectation}`, undefined, undefined, {isNot}), | ||
| `${receivedColor( | ||
| 'expected', | ||
| )} value must be a string or a valid ReactComponent.`, |
Contributor
There was a problem hiding this comment.
Suggested change
| )} value must be a string or a valid ReactComponent.`, | |
| )} value must be a string or a valid React component.`, |
lemonmade
approved these changes
Sep 26, 2019
packages/react-testing/CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Both `toContainReactComponent` and `toContainReactComponentTimes` matcher will now throw error if expected value is `null` or `undefined` ([#1047](https://github.com/Shopify/quilt/pull/1047)) |
Member
There was a problem hiding this comment.
Suggested change
| - Both `toContainReactComponent` and `toContainReactComponentTimes` matcher will now throw error if expected value is `null` or `undefined` ([#1047](https://github.com/Shopify/quilt/pull/1047)) | |
| - Both `toContainReactComponent` and `toContainReactComponentTimes` matcher will now throw a more useful error if the expected value is `null` or `undefined` ([#1047](https://github.com/Shopify/quilt/pull/1047)) |
| type: unknown, | ||
| {expectation, isNot}: {expectation: string; isNot: boolean}, | ||
| ) { | ||
| if (type == null || type === undefined) { |
Member
There was a problem hiding this comment.
type == null is all you need here
michenly
force-pushed
the
check-type
branch
5 times, most recently
from
c00451f to
69cc0fc
Compare
michenly
force-pushed
the
check-type
branch
from
69cc0fc to
26a07d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ined.
Description
Fixes #981
When
PayoutLayoutis undeifnedBefore:
After:
Type of change
Checklist