Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

Upgrade webpack-virtual-modules#1484

Merged
ismail-syed merged 1 commit intomasterfrom
upgrade-webpack-virtual-modules
May 29, 2020
Merged

Upgrade webpack-virtual-modules#1484
ismail-syed merged 1 commit intomasterfrom
upgrade-webpack-virtual-modules

Conversation

@ismail-syed
Copy link
Copy Markdown
Contributor

@ismail-syed ismail-syed commented May 29, 2020

Description

This PR upgrades webpack-virtual-modules and also adds a test the magic-entries-webpack-plugin to verify that it creates magic entries from virtual modules. This ability was provided free by upgrading the webpack-virutual-modules plugin

Type of change

  • Patch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above

@ismail-syed ismail-syed force-pushed the upgrade-webpack-virtual-modules branch 3 times, most recently from a85625f to a54c2ae Compare May 29, 2020 21:46
"!tsconfig.tsbuildinfo"
]
],
"devDependencies": {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this for the editor to pick up these modules in tests.

@ismail-syed ismail-syed force-pushed the upgrade-webpack-virtual-modules branch 2 times, most recently from 97d881f to 8b1fecd Compare May 29, 2020 21:52
@ismail-syed ismail-syed requested a review from marutypes May 29, 2020 22:11
@ismail-syed ismail-syed force-pushed the upgrade-webpack-virtual-modules branch from 8b1fecd to 84c2fd3 Compare May 29, 2020 22:32
@ismail-syed ismail-syed merged commit becf433 into master May 29, 2020
@ismail-syed ismail-syed temporarily deployed to production May 29, 2020 23:01 Inactive
@michenly michenly temporarily deployed to gem June 2, 2020 23:08 Inactive
@michenly michenly deleted the upgrade-webpack-virtual-modules branch June 3, 2020 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants