Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

🐛 update react-network apply context to only set cookie if the value …#1515

Merged
kvendrik merged 4 commits intomasterfrom
only-re-set-cookie-on-change
Jun 16, 2020
Merged

🐛 update react-network apply context to only set cookie if the value …#1515
kvendrik merged 4 commits intomasterfrom
only-re-set-cookie-on-change

Conversation

@michenly
Copy link
Copy Markdown
Contributor

@michenly michenly commented Jun 16, 2020

…had been changed

Description

Fixes (issue #) https://github.com/Shopify/signage/issues/145

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@michenly michenly requested review from kvendrik and marutypes June 16, 2020 18:50
Comment thread packages/react-network/src/server.ts Outdated
@kvendrik kvendrik merged commit 30a0dab into master Jun 16, 2020
@kvendrik kvendrik deleted the only-re-set-cookie-on-change branch June 16, 2020 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants