Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

[use-import-remote] exporting useImportRemote hook#1634

Merged
dleroux merged 2 commits intomasterfrom
export-import-hook
Sep 15, 2020
Merged

[use-import-remote] exporting useImportRemote hook#1634
dleroux merged 2 commits intomasterfrom
export-import-hook

Conversation

@dleroux
Copy link
Contributor

@dleroux dleroux commented Sep 14, 2020

Description

This exports the useImportRemote hook wasn't exported from the package.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@dleroux dleroux changed the title exporting useImportRemote hook [React - use-import-remote] exporting useImportRemote hook Sep 14, 2020
@dleroux dleroux changed the title [React - use-import-remote] exporting useImportRemote hook [use-import-remote] exporting useImportRemote hook Sep 14, 2020
@dleroux dleroux marked this pull request as ready for review September 14, 2020 20:44
@dleroux
Copy link
Contributor Author

dleroux commented Sep 14, 2020

Not sure if this should be considered a patch or minor?

@dleroux dleroux requested a review from cartogram September 14, 2020 20:45

<!-- ## [Unreleased] -->

- Exported `useImportRemote` hook and `Status`([1634](https://github.com/Shopify/quilt/pull/1634))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything has been released not sure if this is the proper way to add an unreleased change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right 👍

@cartogram
Copy link
Contributor

@dleroux I think patch

@dleroux dleroux merged commit 804f575 into master Sep 15, 2020
@dleroux dleroux deleted the export-import-hook branch September 15, 2020 20:45
@michenly michenly temporarily deployed to production September 16, 2020 20:44 Inactive
@marutypes marutypes temporarily deployed to gem February 8, 2021 15:51 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants