This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Conversation
marutypes
commented
Jul 28, 2021
| ), | ||
| ] | ||
| : []; | ||
| try { |
Contributor
Author
There was a problem hiding this comment.
this now throws an error rather than returning null, so we need to wrap it in a try to get at that.
marutypes
commented
Jul 28, 2021
| [Error: Error parsing 'packages/graphql-validate-fixtures/test/fixtures/malformed-query/queries/Another.graphql': | ||
|
|
||
| Syntax Error: Expected {, found Name "name"] | ||
| Syntax Error: Expected "{", found Name "name".] |
Contributor
Author
There was a problem hiding this comment.
some minor error message changes also meant we needed to regen our snapshots
marutypes
commented
Jul 28, 2021
| Object { | ||
| "keyPath": "generation", | ||
| "message": "value does not match enum Generation (available values: FIRST, SECOND, THIRD)", | ||
| "message": "Value \\"SEVENTH\\" does not exist in \\"Generation\\" enum.", |
Contributor
Author
There was a problem hiding this comment.
these snapshots changed more because they come from the try / catch we added (they used to be a custom error)
marutypes
commented
Jul 28, 2021
| ] | ||
| : []; | ||
| try { | ||
| return type.parseValue(value) == null |
Contributor
Author
There was a problem hiding this comment.
we still try to do this so that we support 14.x
Contributor
Author
|
hmm looks like we got some TS errors, weird since I didn't see those running |
marutypes
force-pushed
the
support-graphql-15.x
branch
2 times, most recently
from
26c726f to
8bff4f6
Compare
marutypes
force-pushed
the
support-graphql-15.x
branch
from
bb73839 to
e6b5084
Compare
added 2 commits
August 24, 2021 15:56
vsumner
force-pushed
the
support-graphql-15.x
branch
from
e6b5084 to
53294f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our version ranges meant that projects with dependencies that want
graphql@15.xwould have (possibly worrisome) duplicate graphql dependencies.Checklist