Add generics to findWhere and findWhereAll in react-testing

[BPScott]

Description

findWhere and findAllWhere previously always returned Element<unknown> which meant that code didn't know the type of the element returned And thus you got TS errors (forgive this trivial example, where using find would be preferred):

const wrapper = mount(<div><form method="GET">Hello</form></div>);

const form = wrapper.findWhere((node) => node.is('form'))!;
// This line is a type error because form is typed as `Element<unknown>` 
// which means that the prop (and trigger etc) methods do not know the
// props present on the element so it claims the `method` prop does not exist
const method = form.prop('method');

This PR adds a generic type to findWhere and findAllWhere` so that you can specify the type of element that you shall be returning.

const wrapper = mount(<div><form method="GET">Hello</form></div>);

const form = wrapper.findWhere<'form'>((node) => node.is('form'))!;
// form is now typed an Element with the props of a form element, which
// means that this line now passes
const method = form.prop('method');

This generic type is either a string referring to a html element ('div', 'form' etc), or a React component (Card etc). This is the same type as what you can pass into find as it's first argument.

Type of change

• react-testing: minor

[michenly]

😅

[BPScott]

The find docs reference you and Gord, I'm just being consistent :p

[michenly]

I am actually a little surprise its wrapper.findWhere<MyComponent> and not wrapper.findWhere<type of MyComponent>, the new version of TS got smarter again?

[BPScott]

Excellent spot, the typeof totally needs to be there

[michenly]

lol it would be so nice if typescript is smart enough in the future to know it should use the typeof in generic

[michenly]

🎩 locally with Ben and it looks good to me!