This repository was archived by the owner on Jan 10, 2025. It is now read-only.
fix types for tests for non-react packages#2011
Merged
peter-hamilton merged 9 commits intomainfrom Aug 25, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabled type checking for tests in a number of quilt packages.
Changes
Intl.DateTimeFormatOptionstype for options.() => Promise.resolveOptions.deliveryMethodan optional parameter because it has a default value inregisterWebhook(). Tests were using the default value.'unstable'for cases whereapiVersionwas missing in tests.| undefinedcausing assignment errors. Fixed with non-null assertion operators.webpack.Stats.ToJsonOutput.modulesparam.namevariable was being passed to several mock functions, but wasn't defined. Usedstatsvariable to align with the other tests.Workerimport changed toWebWorkerpage.waitForSelectorgetTestClassInstanceCounttypescript complains that the function signatures betweenPageandExecutionContextaren't compatible. Solved by adding typeguards and duplicating the function calls. Couldn't find a cleaner solution.Type of change
Checklist