This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Update react-network to support node http IncomingHttpHeaders type#2127
Merged
Update react-network to support node http IncomingHttpHeaders type#2127
Conversation
atesgoral
approved these changes
Jan 12, 2022
shopify-shipit
bot
temporarily deployed
to
react-i18n-remove-exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@shopify/react-networkNetworkManager header typescript type is currently an object, koa updated it's header signature to be nodes IncomingHttpHeaders type.This PR updates the type signature to accept it as well as an object.
Fixes (issue #)
Type of change
@shopify/networkPatch: Bug (non-breaking change which fixes an issue)Checklist