This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Triggerkeypath now fails typecheck on invalid array indices#2404
Merged
melnikov-s merged 1 commit intomainfrom Sep 6, 2022
Merged
Triggerkeypath now fails typecheck on invalid array indices#2404melnikov-s merged 1 commit intomainfrom
melnikov-s merged 1 commit intomainfrom
Conversation
BPScott
approved these changes
Sep 6, 2022
melnikov-s
force-pushed
the
react-testing-trigger-key-path-fix-index
branch
from
3241e8a to
afdf2f9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
triggerKeypathis supposed to fail when accessing an array index with an invalid value (not an integer) ieThis never worked due to an incorrect
extendsclause. This PR will no correctly flag the above as a type error.