Skip to content
This repository was archived by the owner on Jan 10, 2025. It is now read-only.

Remove last require() in react-testing so we can use it with a modern tests runner#2540

Merged
phbou72 merged 3 commits intomainfrom
remove-require-for-esm
Jan 27, 2023
Merged

Remove last require() in react-testing so we can use it with a modern tests runner#2540
phbou72 merged 3 commits intomainfrom
remove-require-for-esm

Conversation

@phbou72
Copy link
Contributor

@phbou72 phbou72 commented Jan 26, 2023

Description

Remove last require() in react-testing so we can use it with a modern tests runner that bundle ESM.

@phbou72 phbou72 requested a review from a team as a code owner January 26, 2023 17:35
@phbou72 phbou72 force-pushed the remove-require-for-esm branch from 63025dc to 5516a25 Compare January 26, 2023 17:38
@phbou72
Copy link
Contributor Author

phbou72 commented Jan 26, 2023

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @phbou72! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @shopify/react-testing@0.0.0-snapshot-20230126174808

@phbou72
Copy link
Contributor Author

phbou72 commented Jan 26, 2023

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @phbou72! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @shopify/react-testing@0.0.0-snapshot-20230126180030

@phbou72 phbou72 force-pushed the remove-require-for-esm branch from cb3b788 to c9439d8 Compare January 27, 2023 14:07
@phbou72 phbou72 merged commit 8ba6cbb into main Jan 27, 2023
@phbou72 phbou72 deleted the remove-require-for-esm branch January 27, 2023 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants