This repository was archived by the owner on Jan 10, 2025. It is now read-only.
🐛[react-testing] explicitly typing findWhere and findAllWhere#795
Merged
patsissons merged 1 commit intomasterfrom Jul 16, 2019
Merged
🐛[react-testing] explicitly typing findWhere and findAllWhere#795patsissons merged 1 commit intomasterfrom
patsissons merged 1 commit intomasterfrom
Conversation
patsissons
changed the title
patsissons
force-pushed
the
react-testing-fix-find-typing
branch
from
2c54e8e to
412ac34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the
findWhere()andfindAllWhere()operators are currently untyped due to re-entrancy issues.This PR is explicitly typing these operators to deal with the issue.
Type of change
react-testingPatch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)Checklist