Merged
Conversation
tra0x
force-pushed
the
tra0x/fix-cloudflare-normalization
branch
3 times, most recently
from
6074b1b to
2e3d547
Compare
Cloudflare API returns records with lowercase names and values. This commit normalizes the zone file records before comparing them.
tra0x
force-pushed
the
tra0x/fix-cloudflare-normalization
branch
from
2e3d547 to
c6fad20
Compare
anaclaudiar
reviewed
Nov 4, 2024
|
|
||
| assert_kind_of(Record::PTR, record) | ||
| assert_equal('host.record-store-dns-tests.shopitest.com.', record.ptrdname) | ||
| assert_equal('tbnbz2ni.byoip.example.com.', record.ptrdname) |
Contributor
There was a problem hiding this comment.
I was expecting to see one test with capital letters like TBnbz2ni... no?
pascal-de-ladurantaye
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalization has been incorporated into the
Changesetclass, where diffs are calculated. Since providers are solely responsible for retrieving current records and do not participate in the diff calculations, it was not feasible to limit normalization to just the Cloudflare provider alone.