Fix test failures due to example.com DNS hosting change to Cloudflare#303
Merged
charlescng merged 3 commits intomainfrom Jan 6, 2026
Merged
Fix test failures due to example.com DNS hosting change to Cloudflare#303charlescng merged 3 commits intomainfrom
charlescng merged 3 commits intomainfrom
Conversation
Example.com has migrated from IANA nameservers to Cloudflare. This change updates tests to reflect the new Cloudflare nameservers (hera.ns.cloudflare.com and elliott.ns.cloudflare.com). Additionally, root servers now return authoritative SOA answers for example.com instead of NS referrals. Updated the DNS query logic to handle this by fetching NS records directly when we receive an authoritative SOA answer. Also added the csv gem as a runtime dependency for Ruby 3.4+ compatibility, as it was removed from the standard library. Changes: - Updated test expectations in ZoneTest and CLI::InfoTest for Cloudflare nameservers - Modified fetch_authority to handle SOA answer sections from authoritative servers - Added fetch_ns_records and fetch_ns_records_for_domain methods - Added csv gem to runtime dependencies 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Fixed line length violation by splitting long conditional - Added empty lines after guard clauses - Changed 'return nil' to 'return' - Removed extra spacing - Added parentheses to test method calls 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
charlescng
commented
Jan 6, 2026
charlescng
commented
Jan 6, 2026
charlescng
commented
Jan 6, 2026
tra0x
approved these changes
Jan 6, 2026
Contributor
tra0x
left a comment
tra0x
left a comment
There was a problem hiding this comment.
Good bugfix here regarding authority walking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Example.com has migrated from IANA nameservers (a.iana-servers.net, b.iana-servers.net) to Cloudflare nameservers (hera.ns.cloudflare.com, elliott.ns.cloudflare.com).
Additionally, root DNS servers now return authoritative SOA answers for example.com instead of NS referrals. This required updating the
fetch_authoritymethod to detect when we receive an authoritative answer and fetch NS records directly.The csv gem was also added as a runtime dependency since Ruby 3.4 removed it from the standard library, which was causing LoadError exceptions.
Changes
ZoneTest#test_fetch_authorityandCLI::InfoTest#test_lists_authoritative_nameserversto use Cloudflare nameserversZone#fetch_authorityto handle SOA answer sections from authoritative serversfetch_ns_recordsandfetch_ns_records_for_domainhelper methodsTest plan
bundle exec rake test- all tests pass (0 failures, unrelated Oracle Cloud DNS VCR errors remain)ZoneTest#test_fetch_authoritypasses with new Cloudflare nameserversCLI::InfoTest#test_lists_authoritative_nameserverspassestest_fetch_authority*tests pass including NXDOMAIN handling🤖 Generated with Claude Code