fix event listener methods not being bound correctly#570
Merged
Conversation
robin-drexler
force-pushed
the
rd/fix-event-polyfill
branch
4 times, most recently
from
d42033d to
4a42f36
Compare
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @robin-drexler! Your snapshots have been published to npm. Test the snapshots by updating your "@remote-dom/core": "0.0.0-snapshot-20250522201554",
"@remote-dom/polyfill": "0.0.0-snapshot-20250522201554" |
lemonmade
approved these changes
Jun 3, 2025
| for (const [key, descriptor] of Object.entries( | ||
| eventTargetPrototypeProperties, | ||
| )) { | ||
| eventTargetPrototypeProperties[key] = { |
Contributor
There was a problem hiding this comment.
Could we just mutate the underlying descriptor instead of creating a new one?
robin-drexler
force-pushed
the
rd/fix-event-polyfill
branch
from
4a42f36 to
33baaba
Compare
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @robin-drexler! Your snapshots have been published to npm. Test the snapshots by updating your "@remote-dom/core": "0.0.0-snapshot-20250603142616",
"@remote-dom/polyfill": "0.0.0-snapshot-20250603142616" |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.