more prep for oidc#608
Merged
Merged
Conversation
robin-drexler
commented
Apr 28, 2026
| branches: [main] | ||
| branches: | ||
| - main | ||
| - changeset-release/main |
Member
Author
There was a problem hiding this comment.
needed because this is where preview-versions ran before
robin-drexler
force-pushed
the
rd/prepare-oidcs
branch
from
a5a81fa to
7482255
Compare
Closed
robin-drexler
commented
Apr 29, 2026
| @@ -1 +1 @@ | |||
| v20.11.0 | |||
| v20.20.0 | |||
Member
Author
There was a problem hiding this comment.
seems needed for npm in the version that we want
andrewmcgov
approved these changes
Apr 29, 2026
andrewmcgov
left a comment
andrewmcgov
left a comment
There was a problem hiding this comment.
Looks good! Thanks for doing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Npm only allows one singular action be be allow-listed so we need to move everything that publishes into
deploy.ymlThat means that each job now needs to check if it actually should be running by adding a bunch of checks in the
ifblock.this is a similar setup to what we have in ui-extensions: https://github.com/Shopify/ui-extensions/blob/2026-07-rc/.github/workflows/deploy.yml
See https://shopify.slack.com/archives/C01MXHNTT4Z/p1777390651870159?thread_ts=1777312754.951729&cid=C01MXHNTT4Z for more context
🎩
I'm afraid we'll have to merge and try this. 🙃