Repeat log prefix on each line of multi-line output#893
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1525c26 to
2b8d31c
Compare
Contributor
I like that idea. The dots do look intentional, and it is more robust to potential whitespace stripping :) |
juniper-shopify
requested changes
May 25, 2026
2b8d31c to
6950523
Compare
This was referenced May 27, 2026
juniper-shopify
approved these changes
May 28, 2026
Contributor
juniper-shopify
left a comment
There was a problem hiding this comment.
I'm happy with this as it is, as long as we follow up with a better version of stdout/stderr detection for the colourizer, like you're already working on in #903
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #876
The goal of this PR is to clean up the output of workflow runs by making it easier to read and understand which lines are part of which action.
Examples
Old terminal output New terminal output:

Old log output New log output

Note: went with dots on continuation lines instead of whitespace so the "missing" prefix reads as intentional rather than looking like a rendering glitch or a dropped line. It also avoids touching
msg2str, which strips leading/trailing whitespace. Any future.stripadded elsewhere in the pipeline could also silently collapse a whitespace prefix.