Replace case statement in Claude Message.from_hash with dynamic class resolution#913
Open
juniper-shopify wants to merge 1 commit into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
juniper-shopify
changed the title
|
|
||
| private | ||
|
|
||
| #: (Symbol?) -> Class |
Contributor
There was a problem hiding this comment.
I think changing this to #: (Symbol?) -> singleton(Message) would be more precise and fix the failing CI check.
| def resolve_message_class(type) | ||
| return Messages::UnknownMessage if type.nil? | ||
|
|
||
| class_name = "#{type}_message".camelize |
Contributor
There was a problem hiding this comment.
Are we ever concerned by the fact that .camelize could give us a result that generates a nameError when evaluated in Messages.const_defined?(class_name, false) (such as if the type has a hyphen)?
We can expect that it shouldn't really happen but it might be worth it to add a rescue nameErrorthat also returns Messages::UnknownMessagefor extra robustness.
Contributor
There was a problem hiding this comment.
This would be a useful thing to write a test to validate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #911