Merged
Conversation
paracycle
reviewed
Oct 28, 2025
rafaelfranca
force-pushed
the
rm-release
branch
from
e037c0e to
adbdbef
Compare
paracycle
approved these changes
Oct 28, 2025
Morriar
approved these changes
Oct 28, 2025
Morriar
reviewed
Oct 28, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "name": "ruby-definitions", | |||
| "image": "ghcr.io/rails/devcontainer/images/ruby:3.3.0", | |||
There was a problem hiding this comment.
Any reason we're not using 3.4.7 like https://github.com/Shopify/autotuner/blob/main/.devcontainer/devcontainer.json#L6?
Member
Author
There was a problem hiding this comment.
3.4.7 you mean? Because this project is forcing 3.3.0 in the .ruby-version file https://github.com/Shopify/ruby-definitions/blob/main/.ruby-version
We can do that in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trusted Publishing is enabled for this gem now.
In order to release, you just need to create a new release in the https://github.com/Shopify/ruby-definitions/releases page, based in an existing tag with the
v*format, and another member of the team approve that specific release.