Skip to content

Conversation

@st0012
Copy link
Member

@st0012 st0012 commented Sep 21, 2023

Changes:

  • Use the latest Prism-based ruby-lsp and change node types and namespaces...etc.
  • Rename all [Ee]xtension to [Aa]ddon so we can pass type-checking and tests.
  • Some tests were using AST nodes for testing, which IMO is a bit hard to maintain and doesn't match the testing style of ruby-lsp. So I updated them all to use source-based approach and extracted boilerplate code into helpers.

@st0012 st0012 added the enhancement New feature or request label Sep 21, 2023
@st0012 st0012 added this to the 2023-Q3 milestone Sep 21, 2023
@st0012 st0012 self-assigned this Sep 21, 2023
@st0012 st0012 force-pushed the migrate-to-yarp branch 2 times, most recently from f1988a6 to 3272c1d Compare October 3, 2023 20:07
@st0012 st0012 marked this pull request as ready for review October 3, 2023 20:13
@st0012 st0012 requested a review from a team as a code owner October 3, 2023 20:13
@st0012 st0012 requested review from KaanOzkan and vinistock October 3, 2023 20:13
@st0012 st0012 merged commit 379dfc4 into main Oct 4, 2023
@st0012 st0012 deleted the migrate-to-yarp branch October 4, 2023 14:17
@shopify-shipit shopify-shipit bot temporarily deployed to production October 4, 2023 18:03 Inactive
@vinistock vinistock mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants