Skip to content

Update links to stay within Ruby LSP docs#3263

Merged
andyw8 merged 3 commits intomainfrom
andyw8/update-troubleshooting-links
Mar 4, 2025
Merged

Update links to stay within Ruby LSP docs#3263
andyw8 merged 3 commits intomainfrom
andyw8/update-troubleshooting-links

Conversation

@andyw8
Copy link
Contributor

@andyw8 andyw8 commented Mar 3, 2025

No description provided.

@andyw8 andyw8 added the chore Chore task label Mar 3, 2025
@andyw8 andyw8 requested a review from a team as a code owner March 3, 2025 13:51
@graphite-app
Copy link

graphite-app bot commented Mar 3, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@andyw8 andyw8 force-pushed the andyw8/update-troubleshooting-links branch from 169d782 to e4c7914 Compare March 4, 2025 01:52
@andyw8 andyw8 requested a review from vinistock March 4, 2025 01:54
@andyw8
Copy link
Contributor Author

andyw8 commented Mar 4, 2025

Note that the default navigation sidebar navigation has the extension, so we're essentially publishing the same content at two different URIs. I don't think it's a big concern though.

Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the default navigation sidebar navigation has the extension, so we're essentially publishing the same content at two different URIs. I don't think it's a big concern though.

I'm not sure what you mean. What content is duplicated? And is this a result of updating these links?

@andyw8
Copy link
Contributor Author

andyw8 commented Mar 4, 2025

e.g. we have the same content at

https://shopify.github.io/ruby-lsp/vscode-extension.html
and
https://shopify.github.io/ruby-lsp/vscode-extension

Previously we only had links to the .html versions, so search engines should have only indexed that. But now they will index both, which might affect the weighting of pages in results.

@vinistock
Copy link
Member

I see what you mean. I don't know enough about SEO to say how much the links would impact search engines. If it works locally and in prod, we can use any of the options as long as its standardized.

@andyw8 andyw8 merged commit 6f93d7b into main Mar 4, 2025
43 checks passed
@andyw8 andyw8 deleted the andyw8/update-troubleshooting-links branch March 4, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments