Handle visibility in go to definition#4095
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom May 8, 2026
Merged
Handle visibility in go to definition#4095vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
Conversation
vinistock
added
server
19 tasks
vinistock
force-pushed
the
vs_handle_visibility_in_definition
branch
from
303127b to
8d34acd
Compare
Morriar
approved these changes
May 8, 2026
vinistock
merged commit b2a6eff
into
rubydex_adoption_feature_branch
35 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Now that Rubydex exposes the visibility API, we can handle it correctly in go to definition.
Implementation
Added a helper to check if a method is reachable from the current lexical scope and self type, so that we can handle protected methods correctly.
Automated Tests
Added some new tests.