Handle visibility in hover#4097
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom May 8, 2026
Merged
Conversation
vinistock
added
server
19 tasks
st0012
reviewed
May 8, 2026
vinistock
force-pushed
the
vs_handle_visibility_in_definition
branch
from
303127b to
8d34acd
Compare
vinistock
force-pushed
the
vs_handle_visibility_in_hover
branch
from
2b8cb77 to
bc7e06a
Compare
Morriar
approved these changes
May 8, 2026
Base automatically changed from
vs_handle_visibility_in_definition
to
rubydex_adoption_feature_branch
May 8, 2026 16:03
vinistock
force-pushed
the
vs_handle_visibility_in_hover
branch
from
bc7e06a to
5dfd9f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR starts using the new visibility APIs to handle hover correctly.
Implementation
This PR is based on the go to definition branch, so I extracted the helpers into
Commonand used it for both.Automated Tests
Added tests ensuring we only show hover for reachable methods and constants.