Use Rubydex for method hover#4099
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom May 8, 2026
Merged
Conversation
vinistock
added
server
Morriar
approved these changes
May 8, 2026
vinistock
force-pushed
the
vs_migrate_signature_help_to_rubydex
branch
from
0edb1e8 to
b3e7d40
Compare
Base automatically changed from
vs_migrate_signature_help_to_rubydex
to
rubydex_adoption_feature_branch
May 8, 2026 17:18
vinistock
force-pushed
the
vs_use_rubydex_for_method_hover
branch
from
ff3d500 to
ee0d25b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we have
MethodDefinition#signatures, we can finish migrating hover.Implementation
Moved all signature related helpers to a patch like we're doing for other LSP related functionality. It's based on the old indexer implementation.
Automated Tests
Kept the same tests, but simplified the RBS related ones.