Skip to content

Use Rubydex for method completion resolve#4100

Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
vs_use_rubydex_for_method_completion_resolve
May 8, 2026
Merged

Use Rubydex for method completion resolve#4100
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
vs_use_rubydex_for_method_completion_resolve

Conversation

@vinistock
Copy link
Copy Markdown
Member

Motivation

Almost exactly the same change as we did for hover, but this time for completion resolve. We show documentation for methods including their signatures.

Implementation

Just used the created helpers to show the method's signature.

Automated Tests

Simplified the RBS test, but kept the rest the same.

@vinistock vinistock requested review from Morriar, alexcrocha and st0012 May 8, 2026 14:20
@vinistock vinistock self-assigned this May 8, 2026
@vinistock vinistock requested a review from a team as a code owner May 8, 2026 14:20
@vinistock vinistock added server This pull request should be included in the server gem's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels May 8, 2026
Comment thread lib/ruby_lsp/requests/completion_resolve.rb Outdated
@vinistock vinistock force-pushed the vs_use_rubydex_for_method_hover branch from ff3d500 to ee0d25b Compare May 8, 2026 17:21
Base automatically changed from vs_use_rubydex_for_method_hover to rubydex_adoption_feature_branch May 8, 2026 17:21
@vinistock vinistock force-pushed the vs_use_rubydex_for_method_completion_resolve branch from e8f4dee to 727720e Compare May 8, 2026 17:22
@vinistock vinistock force-pushed the vs_use_rubydex_for_method_completion_resolve branch from 727720e to 6b2ba19 Compare May 8, 2026 17:23
@vinistock vinistock merged commit b9b9e9e into rubydex_adoption_feature_branch May 8, 2026
32 of 33 checks passed
@vinistock vinistock deleted the vs_use_rubydex_for_method_completion_resolve branch May 8, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants