Use Rubydex for method completion resolve#4100
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom May 8, 2026
Merged
Conversation
Morriar
approved these changes
May 8, 2026
ff3d500 to
ee0d25b
Compare
Base automatically changed from
vs_use_rubydex_for_method_hover
to
rubydex_adoption_feature_branch
May 8, 2026 17:21
e8f4dee to
727720e
Compare
727720e to
6b2ba19
Compare
b9b9e9e
into
rubydex_adoption_feature_branch
32 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Almost exactly the same change as we did for hover, but this time for completion resolve. We show documentation for methods including their signatures.
Implementation
Just used the created helpers to show the method's signature.
Automated Tests
Simplified the RBS test, but kept the rest the same.