Remove old indexer#4101
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom May 8, 2026
Merged
Conversation
vinistock
added
breaking-change
19 tasks
Morriar
approved these changes
May 8, 2026
alexcrocha
approved these changes
May 8, 2026
vinistock
merged commit 079aba7
into
rubydex_adoption_feature_branch
51 of 52 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR removes the old Ruby LSP code indexer, now that we finished migrating all of the requests.
Basically, I removed the
ruby_indexerdirectory + some other things I knew had to be adjusted. After that, it was iteration with the tests until every remaining reference to the old index was gone.The only slightly surprising thing is that I removed everything related to handling the index configuration file. Since we want Rubydex to be the base for multiple tools, I don't know if it makes sense for the LSP to configure indexing or if we need a separate
rubydex.jsonfile. I think it needs a bit more discussion, so for now I just removed it.