Skip to content

Improve minitest detection accuracy #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

Improve minitest detection accuracy #770

merged 1 commit into from
Jun 20, 2023

Conversation

@andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jun 20, 2023

Closes #768

@andyw8 andyw8 force-pushed the andyw8/improve-minitest-detection-accuracy branch from e2be425 to 7fefbf2 Compare June 20, 2023 15:27
@andyw8 andyw8 marked this pull request as ready for review June 20, 2023 15:27
@andyw8 andyw8 requested a review from a team as a code owner June 20, 2023 15:27
@andyw8 andyw8 requested review from egiurleo and st0012 June 20, 2023 15:27
@andyw8 andyw8 force-pushed the andyw8/improve-minitest-detection-accuracy branch from 7fefbf2 to 064f4a6 Compare June 20, 2023 15:27
@andyw8 andyw8 force-pushed the andyw8/improve-minitest-detection-accuracy branch from 064f4a6 to ddf61a4 Compare June 20, 2023 15:27
@andyw8 andyw8 merged commit 9c718a1 into main Jun 20, 2023
@andyw8 andyw8 deleted the andyw8/improve-minitest-detection-accuracy branch June 20, 2023 15:35
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023 •
edited
Loading 

Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.33688 std_dev: 0.009995
          textDocument/diagnostic average: 0.060493 std_dev: 0.013228
      textDocument/selectionRange average: 0.004645 std_dev: 0.000781
            textDocument/codeLens average: 0.002574 std_dev: 0.000456
 textDocument/semanticTokens/full average: 0.002546 std_dev: 0.000597
      textDocument/documentSymbol average: 0.002468 std_dev: 0.000444
        textDocument/documentLink average: 0.002452 std_dev: 0.000421
   textDocument/documentHighlight average: 0.002368 std_dev: 0.000524
        textDocument/foldingRange average: 0.002063 std_dev: 0.000344
textDocument/semanticTokens/range average: 0.001188 std_dev: 0.000347
           textDocument/inlayHint average: 0.000778 std_dev: 0.000163
               codeAction/resolve average: 0.000768 std_dev: 0.00024
               textDocument/hover average: 0.000713 std_dev: 0.000195
    textDocument/onTypeFormatting average: 0.000151 std_dev: 0.000156
          textDocument/formatting average: 9.5e-05 std_dev: 0.000389
          textDocument/codeAction average: 5.1e-05 std_dev: 4.4e-05


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
      textDocument/documentSymbol unchanged
        textDocument/foldingRange unchanged
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve unchanged
          textDocument/completion unchanged
            textDocument/codeLens unchanged

@shopify-shipit shopify-shipit bot temporarily deployed to production June 23, 2023 15:44 Inactive
vinistock pushed a commit that referenced this pull request Feb 28, 2024
@github-actions
Merge pull request #770 from Shopify/dependabot/npm_and_yarn/babel/co…
3878c40 
…re-7.22.11

Bump @babel/core from 7.22.10 to 7.22.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st0012 st0012 st0012 approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo egiurleo was automatically assigned from Shopify/ruby-dev-exp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve minitest detection accuracy

2 participants

@andyw8 @st0012