This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Use rubygems style guide#2
Merged
Merged
Conversation
jenshenny
approved these changes
Oct 29, 2021
jenshenny
left a comment
jenshenny
left a comment
There was a problem hiding this comment.
LGTM, would it be helpful to enable the GH actions in this repo to make sure that this change passes CI?
rochlefebvre
approved these changes
Oct 29, 2021
rochlefebvre
left a comment
rochlefebvre
left a comment
There was a problem hiding this comment.
Good call on picking rubygems' styling. Also, I disabled whitespace change highlighting while reviewing this PR to reduce the clutter:
Author
💯 I was thinking of doing that in a separate change. |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our goal is to eventually move the work on the plugin into RubyGems. To make this as easy as possible I'm adding the RubyGems rubocop rules to the repository and updating the repo accordingly.