This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Check responses from Fulcio/Rekor POSTs, raise unless expected#62
Merged
Merged
Conversation
rochlefebvre
force-pushed
the
raise-on-unexpected-fulcio-rekor-responses
branch
from
da6cf3f to
4bc8603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quick change to raise if Fulcio responds unexpectedly while creating a certificate, and if Rekor does so when creating a log entry.
I thought there was an issue in the backlog to handle this, but I can't find it. Adding a note to flesh out later: https://github.com/Shopify/ruby-sigstore/projects/1#card-76792493