This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Store gem signatures in a hashedrekord#63
Merged
Conversation
rochlefebvre
commented
Feb 15, 2022
| require "rubygems/sigstore/rekor/log_entry" | ||
| require "rubygems/sigstore/rekor/signature" | ||
|
|
||
| class Gem::Sigstore::Rekor::HashedRekord < Gem::Sigstore::Rekor::LogEntry |
Author
There was a problem hiding this comment.
As far as our signature verification logic is concerned, hasked rekords and rekords look the same. I moved all of the signature code into a module. Neither Rekord nor HashedRekord have additional code at the moment.
rochlefebvre
force-pushed
the
use-hashedrekord
branch
from
2dd1a3c to
19c0606
Compare
jchestershopify
approved these changes
Feb 15, 2022
jchestershopify
left a comment
jchestershopify
left a comment
There was a problem hiding this comment.
LGTM. It's nice that we could pull so much into a shared module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uploading a signature into Rekor, we don't need to send the entire artifact contents if we use a hashed rekord instead of a rekord. This speeds up the signing operation for larger gem files. It also removes any limit on the size of the signed gem (currently either 32MB or 128MB).
Besides having a new
type, the resulting log entry body is the same. Rekor does not keep a copy of the artifact itself.See this thread on sigstore Slack if you can.