Conversation
|
Can we/should we move the tag after merging? Seems weird that the 2.5.0 tag would point to code with a different version. |
We can, and (in my opinion) we should, but I don’t know if that’ll cause problems anywhere. I’ll wait for @rafaelfranca’s review. |
(We did.) |
|
Btw, you don't need to manually tag repos when doing a release, Shipit creates and pushes a tag when it is deploying the gem to Rubygems. |
|
It doesn't sign the tag though, so I always create manually to make sure the tag was signed. |
6 participants
We need to bump the version number to get Shipit to publish the gem. The tag and release already exist, and therefore won’t point to this commit, but I don’t think that will cause any real problems.