Add a None Option to DumpDisasm #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyhmiller
requested review from
XrXr,
k0kubun,
maximecb and
tenderlove
as code owners
maximecb
reviewed
Sep 1, 2022
k0kubun
reviewed
Sep 1, 2022
| if let Some(target) = get_option!(dump_disasm) { | ||
| if target == DumpDisasm::All || !cb.outlined { | ||
| match get_option!(dump_disasm) { | ||
| DumpDisasm::All | DumpDisasm::Inlined if cb.inlined() => { |
Member
There was a problem hiding this comment.
I think you intended DumpDisasm::All | (DumpDisasm::Inlined if cb.inlined()), but it seems like it's actually evaluated like (DumpDisasm::All | DumpDisasm::Inlined) if cb.inlined(), so this doesn't print outlined cb.
k0kubun
added a commit
that referenced
this pull request
Sep 1, 2022
* Let --yjit-dump-disasm=all dump ocb code as well * Use an enum instead * Add a None Option to DumpDisasm (#444) * Add a None Option to DumpDisasm * Update yjit/src/asm/mod.rs Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> * Fix a build failure * Use only a single name * Only None will be a disabled case * Fix cargo test * Fix --yjit-dump-disasm=all to print outlined cb Co-authored-by: Jimmy Miller <jimmyhmiller@gmail.com> Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.