Add ability to index an entire workspace#104
Merged
Conversation
Merged
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
466c4e8 to
563662a
Compare
vinistock
force-pushed
the
08-13-hook_up_ruby_api_for_the_global_graph
branch
from
3331efe to
0623f26
Compare
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
563662a to
ad28493
Compare
Merged
Morriar
reviewed
Aug 15, 2025
Contributor
Morriar
left a comment
Morriar
left a comment
There was a problem hiding this comment.
I wonder if we could use something like https://docs.rs/ignore/latest/ignore/ for the parallel walk?
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
ad28493 to
9c7e24d
Compare
vinistock
force-pushed
the
08-13-hook_up_ruby_api_for_the_global_graph
branch
from
0623f26 to
7bd2bc2
Compare
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
bf7fcda to
798b7ec
Compare
Member
Author
To make use of gitignore? I don't think we can assume that git ignored files should not be indexed. I can imagine some app that does some templating of files like Prism and then we'd miss those. |
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
798b7ec to
ab69d15
Compare
Morriar
approved these changes
Aug 18, 2025
vinistock
force-pushed
the
08-13-hook_up_ruby_api_for_the_global_graph
branch
from
7bd2bc2 to
c0e185d
Compare
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
ab69d15 to
acb41e8
Compare
vinistock
force-pushed
the
08-13-hook_up_ruby_api_for_the_global_graph
branch
from
c0e185d to
15d517f
Compare
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
acb41e8 to
9b24573
Compare
vinistock
force-pushed
the
08-13-hook_up_ruby_api_for_the_global_graph
branch
from
15d517f to
96f99e2
Compare
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
9b24573 to
3fd5584
Compare
vinistock
changed the base branch from
08-13-hook_up_ruby_api_for_the_global_graph
to
graphite-base/104
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
3fd5584 to
e680669
Compare
vinistock
force-pushed
the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
from
e680669 to
2b01a03
Compare
Member
Author
Merge activity
|
vinistock
deleted the
08-14-add_the_ability_to_index_a_workspace_with_dependencies
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to index an entire workspace, including its dependencies, in a single API.
For now, I removed the ability to exclude directories. I want to create a proper configuration abstraction to propagate that through indexing.
Also, this gets us one step closer to #75, where we can hook the our CLI at the Ruby level, enabling things like:
To index an entire workspace and verify integrity.
Note: one great aspect of using
Bundler.locked_gems&.specsis that, even ifBundler.setupfailed due to a gem not being installed, it still returns information for all of the gems that are installed. This allows us to partially index dependencies even if bundle install didn't fully succeed.