Conversation
Closes #80. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-index-constants
branch
from
4415e75 to
8af01a9
Compare
vinistock
approved these changes
Aug 25, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
This looks good, but can we please either keep the issue open or create new ones for the cases we're not handling yet (just so that we don't lose track of it)?
I mean constant or write, constant and write, constant operator write and family.
Also, we're not yet handling remembering constant aliases, which we should also create an issue for
This was referenced Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribute to #80.