Merged
Conversation
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
vinistock
approved these changes
Aug 27, 2025
Comment on lines
+423
to
+429
| if let Some(receiver) = node.receiver() { | ||
| self.visit(&receiver); | ||
| } | ||
|
|
||
| if let Some(arguments) = node.arguments() { | ||
| self.visit(&arguments.as_node()); | ||
| } |
Member
There was a problem hiding this comment.
Do we need to visit the receiver and argument? Is there a case where we'd discover something in those? Maybe we can get away not visiting them
Contributor
Author
There was a problem hiding this comment.
Class.new(Bar) do
def foo
puts FOO
end
end.newEven if we don't know how to handle the Class.new yet, the constant references to Bar and FOO require going through the receiver and args.
We can disable it but we'll need to put it back once we collect the references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses #124 (comment)