Conversation
Morriar
force-pushed
the
at-utils-metrics
branch
3 times, most recently
from
91f254f to
764aef8
Compare
vinistock
approved these changes
Jul 4, 2025
| def visit_local_variable_write_node(node) | ||
| @counters[:local_variables] += 1 | ||
| super | ||
| end |
Member
There was a problem hiding this comment.
We're missing global variables
utils/symbol-metrics
Outdated
Comment on lines
+88
to
+94
| paths = ARGV.map do |path| | ||
| if File.directory?(path) | ||
| Dir.glob(File.join(path, "**/*.{rb,rbi}")).select { |file| File.file?(file) } | ||
| else | ||
| [path] | ||
| end | ||
| end.flatten |
Member
There was a problem hiding this comment.
Suggested change
| paths = ARGV.map do |path| | |
| if File.directory?(path) | |
| Dir.glob(File.join(path, "**/*.{rb,rbi}")).select { |file| File.file?(file) } | |
| else | |
| [path] | |
| end | |
| end.flatten | |
| paths = ARGV.flat_map do |path| | |
| if File.directory?(path) | |
| Dir.glob(File.join(path, "**/*.{rb,rbi}")).select { |file| File.file?(file) } | |
| else | |
| [path] | |
| end | |
| end |
alexcrocha
approved these changes
Jul 4, 2025
Useful to get a high level picture of what's in a codebase
and how our things scale in comparison.
Usage:
$ ./utils/symbol-metrics <path> [<path>...]
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful to get a high level picture of what's in a codebase and how our things scale in comparison.
Usage: