Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jenny-codes
changed the title
This was referenced Oct 30, 2025
vinistock
reviewed
Oct 30, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
From our chat: let's either move Database errors out of indexing or make the errors enum more generic.
jenny-codes
force-pushed
the
jennyshih/multiple-error
branch
from
c89b44b to
104f79c
Compare
Contributor
Author
|
@vinistock I chose the second one and renamed the |
jenny-codes
force-pushed
the
jennyshih/multiple-error
branch
from
104f79c to
9241f5d
Compare
jenny-codes
force-pushed
the
jennyshih/multiple-error
branch
from
9241f5d to
10bef90
Compare
jenny-codes
changed the base branch from
graphite-base/284
to
jennyshih/create-index-result
jenny-codes
force-pushed
the
jennyshih/create-index-result
branch
from
4bc044d to
89a65e0
Compare
jenny-codes
force-pushed
the
jennyshih/multiple-error
branch
from
10bef90 to
d55b7d1
Compare
jenny-codes
changed the base branch from
jennyshih/create-index-result
to
graphite-base/284
jenny-codes
force-pushed
the
graphite-base/284
branch
from
89a65e0 to
ed0df88
Compare
jenny-codes
force-pushed
the
jennyshih/multiple-error
branch
from
d55b7d1 to
548ce91
Compare
jenny-codes
force-pushed
the
jennyshih/multiple-error
branch
from
548ce91 to
87b5c3a
Compare
jenny-codes
changed the title
vinistock
approved these changes
Oct 31, 2025
Now that we have DatabaseError IndexingError is not suitable anymore, so changing it to an more generic name.
jenny-codes
force-pushed
the
jennyshih/multiple-error
branch
from
87b5c3a to
c159cf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a more descriptive error type for database errors instead of the generic Box<dyn Error>.
Also renaming the
IndexingError to a more genericErrors type