Split file listing out of indexing#383
Merged
Merged
Conversation
As I'm working to bring back #205, it just makes more sense to have the listing and indexing concepts separate. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Member
|
I'm good with the changes, but I wonder: will the separation make it more difficult to implement your idea of having a queue of work that mixes listing, reading and indexing files? If we plan on moving forward with that, it could be better to implement it first, see the structure that emerges and then separate. |
Contributor
Author
I don't think the file structure will be the limiting factor here. |
vinistock
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I'm working to bring back #205, it just makes more sense to have the listing and indexing concepts separate.