Introduce JobQueue and and use it to list files#394
Merged
Conversation
vinistock
approved these changes
Jan 6, 2026
Member
vinistock
left a comment
There was a problem hiding this comment.
I like this, but still wanted to bring up: does rayon provide us with something like this by default?
I know it has many modes for running code in parallel, so I wonder if bringing rayon back is worth it.
029f550 to
e3b8f73
Compare
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Now that we handle aliases properly we should not fail if one couldn't be resolved properly so instead of a `Result` we return a tuple. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Contributor
Author
Yes to some extent. I found that the main difference is the API we can expose. With the JobQueue the idea is to hide the complexity and just make people implement and push jobs. With Rayon the user of the queue has to handle lower level concept like spawning themselves. In the end I went with the cleaner API to save ourselves some complexity in the usesites. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The queue is backed by
crossbeam::{channel, deque, utils}and provides parallelism, communication through channels and job stealing with backoff.In this PR we migrate the file listing to the
JobQueue, I'll follow up with indexing and resolution.Benchmarks:
Closes #100
Closes #205