Search for closest namespace when connecting definition to declaration

[vinistock]

Finding the declaration for a definition that was nested inside something that isn't a namespace was crashing. For example, this scenario:

class Foo
  def bar
    # This ivar is nested under the `bar` method. To find its declaration, we need
    # to go all the way to `Foo`
    @something = 1
  end
end

The fix is to keep searching for the closest namespace and only default to Object if the definition is not nested under anything.

[vinistock]

• Improve index workspace path discovery #576
• Search for closest namespace when connecting definition to declaration #575 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Morriar]

Naming between lexical_nesting and namespace is getting confusing, we may want to revisit it at some point

[vinistock]

Yes, indeed. What indexing collects isn't really the lexical nesting since methods don't produce lexical scopes. We'll need to review the nomenclature.

[vinistock]

Merge activity

• Feb 10, 3:31 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Feb 10, 3:31 PM UTC: @vinistock merged this pull request with Graphite.