Skip to content

Index modules with RBS indexer#591

Merged
alexcrocha merged 2 commits intomainfrom
02-20-rbs_indexer_modules
Feb 24, 2026
Merged

Index modules with RBS indexer#591
alexcrocha merged 2 commits intomainfrom
02-20-rbs_indexer_modules

Conversation

@alexcrocha
Copy link
Contributor

@alexcrocha alexcrocha commented Feb 21, 2026

One more step towards #87.

This PR starts indexing modules with the RBS indexer.

  • .rbs files are now collected during file discovery (previously, only .rb files were collected)
  • Added new_rbs() to LocalGraphTest so rbs_indexer tests can use the same assertion pattern as ruby_indexer
  • Added index_rbs_uri() to GraphTest as a separate method from index_uri() due to in-memory sources
  • Extracted shared test macros from ruby_indexer to local_graph_test.rs so both indexers can reuse them
    • Diagnostic macros were renamed to assert_local_diagnostics_eq! / assert_no_local_diagnostics! to avoid conflicting with the GraphTest versions in graph_test.rs

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alexcrocha alexcrocha force-pushed the 02-20-rbs_indexer_modules branch 2 times, most recently from 1cbe830 to b542bdd Compare February 23, 2026 17:53
@alexcrocha alexcrocha marked this pull request as ready for review February 23, 2026 18:31
@alexcrocha alexcrocha requested a review from a team as a code owner February 23, 2026 18:31
@alexcrocha alexcrocha added the enhancement New feature or request label Feb 23, 2026
@alexcrocha alexcrocha self-assigned this Feb 23, 2026
@alexcrocha alexcrocha force-pushed the 02-20-rbs_indexer_modules branch from b542bdd to ea79d36 Compare February 24, 2026 17:21
@alexcrocha alexcrocha force-pushed the 02-20-rbs_indexer_modules branch from ea79d36 to 29b264c Compare February 24, 2026 20:40
@alexcrocha alexcrocha requested a review from vinistock February 24, 2026 21:06
@alexcrocha alexcrocha force-pushed the 02-20-rbs_indexer_modules branch from 08bc159 to 3d45472 Compare February 24, 2026 22:48
@alexcrocha alexcrocha merged commit 88e4a9e into main Feb 24, 2026
27 checks passed
@alexcrocha alexcrocha deleted the 02-20-rbs_indexer_modules branch February 24, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants