Follow aliases for completion#600
Open
vinistock wants to merge 1 commit into02-24-provide_completion_for_expressions_inside_call_argumentsfrom
Open
Follow aliases for completion#600vinistock wants to merge 1 commit into02-24-provide_completion_for_expressions_inside_call_argumentsfrom
vinistock wants to merge 1 commit into02-24-provide_completion_for_expressions_inside_call_argumentsfrom
Conversation
This was referenced Feb 24, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
02-24-follow_aliases_for_completion
branch
from
f6a5e39 to
22cf56c
Compare
vinistock
force-pushed
the
02-24-provide_completion_for_expressions_inside_call_arguments
branch
from
291c8f3 to
19864f5
Compare
vinistock
force-pushed
the
02-24-follow_aliases_for_completion
branch
from
22cf56c to
1916ac4
Compare
vinistock
force-pushed
the
02-24-provide_completion_for_expressions_inside_call_arguments
branch
from
19864f5 to
20714f7
Compare
vinistock
force-pushed
the
02-24-follow_aliases_for_completion
branch
2 times, most recently
from
7b7613d to
f026e01
Compare
vinistock
force-pushed
the
02-24-provide_completion_for_expressions_inside_call_arguments
branch
from
20714f7 to
79b4481
Compare
Morriar
approved these changes
Mar 2, 2026
vinistock
force-pushed
the
02-24-provide_completion_for_expressions_inside_call_arguments
branch
from
79b4481 to
9b43f88
Compare
vinistock
force-pushed
the
02-24-follow_aliases_for_completion
branch
from
f026e01 to
2d14e65
Compare
vinistock
force-pushed
the
02-24-provide_completion_for_expressions_inside_call_arguments
branch
2 times, most recently
from
1d446f7 to
ec1706f
Compare
vinistock
force-pushed
the
02-24-follow_aliases_for_completion
branch
from
2d14e65 to
bb484a1
Compare
vinistock
force-pushed
the
02-24-provide_completion_for_expressions_inside_call_arguments
branch
2 times, most recently
from
46e0d94 to
81009f6
Compare
vinistock
force-pushed
the
02-24-follow_aliases_for_completion
branch
from
bb484a1 to
fab3b45
Compare
vinistock
force-pushed
the
02-24-follow_aliases_for_completion
branch
from
fab3b45 to
cca7335
Compare
vinistock
force-pushed
the
02-24-provide_completion_for_expressions_inside_call_arguments
branch
from
81009f6 to
a03508c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts following alias targets for completion. If we have
ALIAS.orALIAS::, we need to search the alias target for candidates, not theConstantAliasitself.My idea was to add a method that keeps tracing alias targets until it finds something that isn't an alias. Then we use that for completion.