Rewrite assert_def_superclass_ref_eq! to support full paths#612
Merged
alexcrocha merged 1 commit intoFeb 27, 2026
Merged
Conversation
alexcrocha
added
the
chore
vinistock
approved these changes
Feb 27, 2026
alexcrocha
deleted the
02-27-rewrite_assert_def_superclass_ref_eq_to_support_full_paths
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewriting
assert_def_superclass_ref_eq!to support full paths, as per post-merge review #606 (comment)Also using this opportunity to remove the redundant
assert!(def.superclass_ref().is_some()).