Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexcrocha
force-pushed
the
02-27-index_globals_with_rbs_indexer
branch
from
cc6bbac to
f77fbfe
Compare
vinistock
approved these changes
Mar 2, 2026
This adds visit_global_node so global variable declarations (e.g., $foo: String) are discovered and resolved as members of Object
alexcrocha
force-pushed
the
02-27-index_globals_with_rbs_indexer
branch
from
f77fbfe to
f7e2542
Compare
alexcrocha
force-pushed
the
02-27-index_constants_with_rbs_indexer
branch
from
ed6eba1 to
60b8df1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more step towards #87.
This PR adds
visit_global_nodeso global variable declarations ($foo: String) are discovered and resolved as members ofObject, matching Ruby indexer's behaviour.