Add method alias inside re-opened alias test#642
Merged
Conversation
vinistock
added
the
chore
Graphite App
Morriar
approved these changes
Mar 5, 2026
| assert_declaration_exists!(context, "Foo#some_attr()"); | ||
| assert_declaration_exists!(context, "Foo::<Foo>#class_method()"); | ||
| assert_declaration_exists!(context, "Foo#initialize()"); | ||
| assert_declaration_exists!(context, "Foo#new_bar()"); |
Contributor
There was a problem hiding this comment.
Should we also assert Foo#bar() (the original method)? The test asserts all other members in the namespace, so I'd expect bar to also be there.
Member
Author
There was a problem hiding this comment.
I think that's overkill. The functionality is already being tested by initialize. I just added bar because aliasing initialize is not common.
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing method alias to our test.