Conversation
vinistock
added
the
bugfix
Graphite App
This reverts commit 6bafe29.
vinistock
force-pushed
the
03-06-remove_cpu-native_config
branch
from
bc440f5 to
c87d64f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We not only continue to see the crashes in our memory leak check, but we are seeing the crash when running regular CI on Ubuntu and in projects adopting Rubydex.
I have one more hypothesis: maybe using
nativeas the target CPU is creating some incompatibility between the Ubuntu environment where the gem gets pre-compiled and the one where it runs.This PR is another attempt to fix this. It reverts the memleak changes and removes our target-cpu. We added the target-cpu for performance, but it makes no actual difference in our benchmarks.