Conversation
Morriar
reviewed
Aug 6, 2025
vinistock
force-pushed
the
08-06-remove_uri_interning_lock
branch
from
d122f25 to
848e65d
Compare
Morriar
approved these changes
Aug 6, 2025
Contributor
Morriar
left a comment
Morriar
left a comment
There was a problem hiding this comment.
Some remaining comments but it can be fixed forward 👍
vinistock
force-pushed
the
08-06-remove_uri_interning_lock
branch
from
848e65d to
512b502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the interning of URIs from the index, so that the threads don't have to compete on any locks and everything is merged at the end.
I also switched to using rayon for parallelism, which makes the implementation much simpler.