Unresolve all names when clearing declarations#670
Merged
Conversation
alexcrocha
approved these changes
Mar 17, 2026
st0012
reviewed
Mar 17, 2026
vinistock
force-pushed
the
03-17-unresolve_all_names_when_clearing_declarations
branch
from
b3994ac to
e26c18e
Compare
vinistock
deleted the
03-17-unresolve_all_names_when_clearing_declarations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until we handle incremental changes, we are deleting all declaration information from the graph. However, that's not enough. We also need to unresolve all names, otherwise we could be left with a resolved name that points to a declaration that no longer exists because it was removed between two resolution runs.
This PR adds a test that reproduces a crash we have and starts unresolving all names in
clear_declarations. This is temporary code, so I also pointed that out in a comment.